Open
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Moves the “achievement placement” background-color styling into Lua-Modules and rewrites the per-placement rules into a single Sass map + @each loop with theme-aware light/dark variants.
Changes:
- Replaces individual
.placement-*background-color rules with a$placement-colorsmap and generated selectors. - Switches placement colors to use the
--clr-*design tokens and theme-specific overrides via.theme--light/.theme--dark. - Introduces
color-mix()for a few runtime-mixed colors (e.g., dark variants of blues, and the “down” light variant).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+1336
to
+1338
| "lightblue": ( var( --clr-elm-40 ), color-mix( in srgb, #000000 20%, var( --clr-elm-40 ) ) ), | ||
| "blue": ( var( --clr-elm-30 ), color-mix( in srgb, #000000 20%, var( --clr-elm-30 ) ) ), | ||
| "darkblue": ( var( --clr-elm-20 ), color-mix( in srgb, #000000 20%, var( --clr-elm-20 ) ) ), |
Comment on lines
+1345
to
+1346
| "down": ( color-mix( in srgb, #ffffff 30%, var( --clr-semantic-negative-40 ) ), var( --clr-semantic-negative-30 ) ), | ||
| "dnp": ( var( --clr-moon-80 ), color-mix( in srgb, #000000 20%, var( --clr-moon-80 ) ) ), |
Contributor
Author
There was a problem hiding this comment.
I think the support for color-mix() is good enough 🤷♀️ https://caniuse.com/?search=color-mix
ElectricalBoy
approved these changes
May 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Moving the placement colors logic from the Lakesideview rep to the Lua-Modules repo.
I don't think Lighthouse should own this because it's only used inside wiki content.
As a reference, these were the colors from Lakesideview:
I also made the code a little shorter and removed the fallback, because always either
theme--lightortheme--darkis applied.Related MR
https://gitlab.com/teamliquid-dev/liquipedia/web/skins/lakesideview/-/merge_requests/192
How did you test this change?
I tested it on https://laura.wiki.tldev.eu/rocketleague/Rocket_League_Championship_Series/2021-22/Fall#Interregional_Matchups
CSS changed here https://laura.wiki.tldev.eu/commons/MediaWiki:Common.css/Miscellaneous.scss